Skip to content

remove 1.1MB (85%) of binary size by not including iostream #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2020
Merged

remove 1.1MB (85%) of binary size by not including iostream #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e65f977
fix: never include iostream unless it's absolutely necessary
biojppm Nov 24, 2020
663fd91
fix: include of iostream is now required on client code
biojppm Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/fast_float/decimal_to_binary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#include <cstdio>
#include <cstdlib>
#include <cstring>
#include <iostream>

namespace fast_float {

Expand Down
4 changes: 2 additions & 2 deletions include/fast_float/float_common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,8 +363,8 @@ constexpr int binary_format<float>::smallest_power_of_ten() {
} // namespace fast_float

// for convenience:
#include <ostream>
inline std::ostream &operator<<(std::ostream &out, const fast_float::decimal &d) {
template<class OStream>
inline OStream& operator<<(OStream &out, const fast_float::decimal &d) {
out << "0.";
for (size_t i = 0; i < d.num_digits; i++) {
out << int32_t(d.digits[i]);
Expand Down
4 changes: 2 additions & 2 deletions tests/exhaustive32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

#include "fast_float/fast_float.h"


#include <iostream>
#include <cassert>
#include <cmath>

Expand Down Expand Up @@ -56,4 +56,4 @@ int main() {
std::cout << std::endl;
std::cout << "all ok" << std::endl;
return EXIT_SUCCESS;
}
}
4 changes: 2 additions & 2 deletions tests/exhaustive32_64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

#include "fast_float/fast_float.h"


#include <iostream>
#include <cassert>
#include <cmath>

Expand Down Expand Up @@ -70,4 +70,4 @@ int main() {
std::cout << std::endl;
std::cout << "all ok" << std::endl;
return EXIT_SUCCESS;
}
}
4 changes: 2 additions & 2 deletions tests/exhaustive32_midpoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "fast_float/fast_float.h"


#include <iostream>
#include <cassert>
#include <cmath>

Expand Down Expand Up @@ -119,4 +119,4 @@ int main() {
std::cout << std::endl;
std::cout << "all ok" << std::endl;
return EXIT_SUCCESS;
}
}
4 changes: 2 additions & 2 deletions tests/long_exhaustive32.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@

#include "fast_float/fast_float.h"


#include <iostream>
#include <cassert>
#include <cmath>

Expand Down Expand Up @@ -57,4 +57,4 @@ int main() {
std::cout << std::endl;
std::cout << "all ok" << std::endl;
return EXIT_SUCCESS;
}
}
4 changes: 2 additions & 2 deletions tests/long_exhaustive32_64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "fast_float/fast_float.h"


#include <iostream>
#include <cassert>
#include <cmath>

Expand Down Expand Up @@ -56,4 +56,4 @@ int main() {
std::cout << std::endl;
std::cout << "all ok" << std::endl;
return EXIT_SUCCESS;
}
}
2 changes: 1 addition & 1 deletion tests/long_random64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "fast_float/fast_float.h"


#include <iostream>
#include <cassert>
#include <cmath>

Expand Down
2 changes: 1 addition & 1 deletion tests/random64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "fast_float/fast_float.h"


#include <iostream>
#include <cassert>
#include <cmath>

Expand Down
4 changes: 3 additions & 1 deletion tests/random_string.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#include "fast_float/fast_float.h"

#include <iostream>
#include <cstdint>
#include <random>

Expand Down Expand Up @@ -212,4 +214,4 @@ int main() {
}
std::cout << "Failure." << std::endl;
return EXIT_FAILURE;
}
}
3 changes: 2 additions & 1 deletion tests/short_random_string.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#include "fast_float/fast_float.h"
#include <iostream>
#include <cstdint>
#include <random>

Expand Down Expand Up @@ -208,4 +209,4 @@ int main() {
}
std::cout << "Failure." << std::endl;
return EXIT_FAILURE;
}
}
2 changes: 1 addition & 1 deletion tests/string_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "fast_float/fast_float.h"

#include <iostream>
#include <vector>

#if defined(__CYGWIN__) || defined(__MINGW32__) || defined(__MINGW64__) || defined(sun) || defined(__sun)
Expand Down