- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 238
Updates and add table #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Still think that we should add a threshold and add more columns to the table :P
        
          
                README.md
              
                Outdated
          
        
      | total.js | 2.9.4 | ✓ | 21019.2 | 4.65 | 6.03 | ||
| trek-engine | 1.0.5 | ✗ | 28718.4 | 3.4 | 4.06 | ||
| trek-router | 1.2.0 | ✓ | 28513.6 | 3.43 | 3.99 | ||
|  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's what benchmarks.js compare -t outputs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but that's a "command line table", not copy-n-paste compatible with markdown. I can update the code to pump out a markdown table, if that's more what you intented.
It's easy though, just wrap that table in ``` and it will look perfectly pretty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need something copy-pastable. I would prefer a markdown table, but I'll just do fine with ``` for now.
        
          
                package.json
              
                Outdated
          
        
      | "ienoopen": "^1.0.0", | ||
| "inquirer": "^5.2.0", | ||
| "koa": "^2.5.0", | ||
| "inquirer": "^3.3.0", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcollina -Is there a reason why some of the packages have been downgraded here? -Also, any particular reason as to why rayo was removed? -Might as well remove it from the results table if you don't see it fit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably messed up with the rebase, let me check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| You can land this :). Thanks to taking it over the finishing line! | 
| No problem @mcollina -Anytime. It's my definition of being a team. | 
No description provided.