Skip to content

Add TS Node environment variable #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

Add TS Node environment variable #355

merged 1 commit into from
May 7, 2021

Conversation

@francisdaigle
Copy link
Contributor

@francisdaigle francisdaigle commented May 2, 2021

TS_NODE_FILES set true so as to load include on startup.

#354

Checklist

@climba03003
Copy link
Member

climba03003 commented May 2, 2021

I do not know if it is a good practice to enable this behavior by default. But it seems that if we use fastify-autoload with typescript, it can resolve a lot of problem.
WDYT @fastify/typescript

@climba03003 climba03003 requested a review from a team May 2, 2021 13:31
mcollina
mcollina approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@francisdaigle
Copy link
Contributor Author

francisdaigle commented May 3, 2021

Apologies -- not a cross-platform solution.

May I update this PR @mcollina?

@climba03003
Copy link
Member

climba03003 commented May 4, 2021

Apologies -- not a cross-platform solution.

May I update this PR @mcollina?

You can update it any time before it merge and re-request for review.

@francisdaigle francisdaigle requested a review from mcollina May 4, 2021 05:18
mcollina
mcollina approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina requested changes May 4, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add cross-env to the devDependencies in the generated package.json.

@francisdaigle francisdaigle requested a review from mcollina May 4, 2021 17:30
mcollina
mcollina approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented May 6, 2021

Can you please rebase it on top of master?

@francisdaigle
Add TS Node environment variable
6a9ea99 
TS_NODE_FILES set "true" so as to load tsconfig "include" on startup.
@francisdaigle francisdaigle force-pushed the feature/modify-test-environment branch from 215a9ff to 6a9ea99 Compare May 6, 2021 18:03
@francisdaigle francisdaigle requested a review from mcollina May 6, 2021 18:04
mcollina
mcollina approved these changes May 7, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit fb4b0aa into fastify:master May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francisdaigle @climba03003 @mcollina