Big numbers (edit: plugin options)

[LizroDev]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the issue has not already been raised

Issue

Hello,
During my queries, large numbers cause a problem: the last digits are replaced by 0. Is it possible to, like mysql2, configure the plugin like this? Normally resolving the problem.

fastify.register(require('fastify-mysql'), {
  promise: true,
  supportBigNumbers: true,
  bigNumberStrings: true,
  connectionString: 'mysql://'+mysqlUser+':'+mysqlPassword+'@'+mysqlHost+':'+mysqlPort+'/'+mysqlDatabase
})

Thanks

[jsumners]

The readme states:

fastify-mysql/README.md

Line 9 in 1000fea

Under the hood the [mysql2](https://github.com/sidorares/node-mysql2) is used, the options that you pass to `register` will be passed to the MySQL pool builder.

[LizroDev]

The readme states:

fastify-mysql/README.md

Line 9 in 1000fea

Under the hood the [mysql2](https://github.com/sidorares/node-mysql2) is used, the options that you pass to `register` will be passed to the MySQL pool builder.

This is not quite correct, after a bit of research in the source code I found the solution to my problem.

fastify-mysql/index.js

Line 67 in 1000fea

client = mysql.createPool(options.connectionString || options)

If a connection String is used, the options are not passed to the pool builder.

Therefore, this works :

fastify.register(require('fastify-mysql'), {
  promise: true,
  host: mysqlHost,
  port: mysqlPort,
  database: mysqlDatabase,
  user: mysqlUser,
  password: mysqlPassword,
  supportBigNumbers: true,
  bigNumberStrings: true
})

but not this

fastify.register(require('fastify-mysql'), {
  promise: true,
  supportBigNumbers: true,
  bigNumberStrings: true,
  connectionString: 'mysql://'+mysqlUser+':'+mysqlPassword+'@'+mysqlHost+':'+mysqlPort+'/'+mysqlDatabase
}) 

The sentence should be changed so as not to be confusing and to be more precise.
Have a good evening

[jsumners]

Would you like to send a Pull Request to address this issue?

[LizroDev]

Of course, it's done !