feat: export RowDataPacket, ResultSetHeader, ProcedureCallPacket from MySQL2 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uzlopak
reviewed
Dec 29, 2023
Contributor
|
Hmm. There is not difference between the Promise typeguards and the normal typeguards?! |
Eomm
requested changes
Feb 10, 2024
marco-ippolito
approved these changes
Feb 10, 2024
Contributor
|
Please not merge yet. Please give me time till mondaY |
gurgunday
approved these changes
Feb 10, 2024
Member
gurgunday
left a comment
gurgunday
left a comment
There was a problem hiding this comment.
It looks good to me as well
dancastillo
force-pushed
the
export-mysql2-types
branch
from
e2ec494 to
9321529
Compare
Member
Author
|
@Uzlopak i updated to distinguish between normal and promise typeguards |
gurgunday
approved these changes
Mar 9, 2024
pioupia
reviewed
Mar 28, 2024
pioupia
left a comment
pioupia
left a comment
There was a problem hiding this comment.
It might be worth testing all possible cases to make sure the return values are right all the time.
Member
Author
dancastillo
force-pushed
the
export-mysql2-types
branch
from
b41d2ab to
b08b412
Compare
Eomm
reviewed
Mar 29, 2024
Member
Eomm
left a comment
Eomm
left a comment
There was a problem hiding this comment.
I can't see the is* functions documentation. Is this wanted?
Member
|
@Eomm ptal |
Eomm
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
fixes: #127
This PR exports RowDataPacket, ResultSetHeader, ProcedureCallPacket from MySQL2 with prefix
MySQLon the typesnpm run testandnpm run benchmarkand the Code of conduct