Skip to content

Conversation

@mcollina
Copy link
Member

Drop support for Node 6 because mysql2@2 does not include it in its .travis.yml. Removes the disclaimer about MySql 8.x, and add it as an npm script to run it.

Checklist

  • run npm run test and npm run benchmark
  • documentation is changed or added
  • commit message and code follows Code of conduct

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SerayaEryn SerayaEryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 5b7a16c into master Oct 30, 2019
@mcollina mcollina deleted the new-major branch October 30, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants