fix: handle missing trailing slash on directories

[disintegrator]

Currently, when fastify-static is configured with redirect option set to false and a request for a directory does not contain a trailing slash, it causes the server to hang. This is because we only register a directory handler on the underlying send stream if redirect option is true.

This PR updates the library to handle such requests by calling reply.callNotFound(). We presume that requesting a directory without using a trailing slash OR setting redirect to true should be handled explicitly as a 404.

To reproduce the bug:

const path = require('path')
const Fastify = require('fastify')
const fastifyStatic = require('fastify-static')

const fastify = Fastify()
fastify.register(fastifyStatic, {
  // using the fixture in fastify-static's test folder
  root: path.join(__dirname, '/test/static'),
  redirect: false
})

fastify.listen(3000, () => {
  console.log('ready')
})

In another terminal, running the following command will hang indefinitely:

curl http://localhost:3000/deep/path/for/test

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[mcollina]

LGTM, good work

[delvedor]

Good catch!

[RafaelGSS]

LGTM