fix for typescript http2/https warning #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hm, change of index.d.ts can break somehow test? |
mcollina
reviewed
Nov 21, 2019
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Can you cover this in the types tests?
Contributor
Author
|
@mcollina changed types/index.ts in fastify-cookies style, if it's what you mean. |
Ethan-Arrowood
suggested changes
Nov 21, 2019
Ethan-Arrowood
approved these changes
Nov 21, 2019
Member
Ethan-Arrowood
left a comment
Ethan-Arrowood
left a comment
There was a problem hiding this comment.
LGTM! Thank you good work 👍
Member
|
@Ethan-Arrowood is this a patch for TS's users? |
Member
|
Yes this is a patch fix 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #114
I'm not an expert in typescript and declaration files, but i was able to adapt fastify-static declaration file in style of fastify-cookie declaration file (that gives no typescript warnings).
Now it should compile without problems for http2 and htpps too.
Checked on my own server with http, http2 and https settings for server.