Support almost all of the same options as serve-static #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Dec 20, 2017
|
|
||
| ``` | ||
|
|
||
| ### Options |
Member
There was a problem hiding this comment.
Can we link to the options in send docs instead? I’m not a fun of duplicating them.
Contributor
Author
There was a problem hiding this comment.
Sure. Would you like me to keep the descriptions for the Fastify options though?
index.js
Outdated
| immutable: opts.immutable, | ||
| index: opts.index, | ||
| lastModified: opts.lastModified, | ||
| maxAge: opts.maxAge || 0 |
Member
There was a problem hiding this comment.
is 0 the default applied in send?
Contributor
Author
There was a problem hiding this comment.
Oh yes. I guess the || 0 isn’t necessary then.
| index: opts.index, | ||
| lastModified: opts.lastModified, | ||
| maxAge: opts.maxAge || 0 | ||
| } |
Member
There was a problem hiding this comment.
Can you add a unit test (maybe using proxyquire)? So we can test that the options are passed through.
nwoltman
force-pushed
the
send-options
branch
from
2f2d5ea to
08b1ee4
Compare
nwoltman
changed the title
Contributor
Author
|
Added tests and updated the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for almost all of the options that
serve-staticsupports, which are mostly just options that can be passed tosend.