Skip to content

Run error handler when an error occurs in a non-async handler #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

Run error handler when an error occurs in a non-async handler #120

merged 1 commit into from
Apr 28, 2021

Conversation

Prinzhorn
Copy link
Contributor

@Prinzhorn Prinzhorn commented Apr 26, 2021 •
edited
Loading

fixes #119

I basically duplicated the other test and removed the async keyword. Without the fix the test would timeout.

Checklist

@Prinzhorn Prinzhorn changed the title Run error handler when an error occurs in a non-async handler, fixes … Run error handler when an error occurs in a non-async handler Apr 26, 2021
mcollina
mcollina approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5012f71 into fastify:master Apr 28, 2021
@Prinzhorn Prinzhorn deleted the error-handler branch April 28, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@airhorns airhorns airhorns approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

An error inside the WebSocket handler results in "Reply was already sent" and not the actual error

3 participants

@Prinzhorn @mcollina @airhorns