fix: generify WebsocketRouteOptions #128
Conversation
| expectType<FastifyRequest<RequestGenericInterface>>(request) | ||
| expectType<FastifyRequest<RouteGenericInterface>>(request) | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Want to add a test for the new functionality based on your original issue? Thanks for the contribution!
There was a problem hiding this comment.
I never really tested "types", didn't know that was a thing until now :D
There was a problem hiding this comment.
So... what next then? :D
There was a problem hiding this comment.
To add a test case you'd need to copy one of these stanzas and exercise specifically the new types you added! I think you could do that by adding a route that uses a specific type for the params or whatever, and then asserting that thats the type of the params you get in the handler. This file is using tsd which is a typescript testing tool and you can find more info in its docs.
|
Can this be merged? |
|
I'm sorry, CI was stuck @fastify/typescript could you take a look? |
|
@VottusCode Do you need any help with this :)? |
|
|
Merged in #176 |
5 participants
Checklist
npm run testandnpm run benchmarkand the Code of conduct
fixes #127