Skip to content

Conversation

Arnovsky
Copy link
Contributor

@Arnovsky Arnovsky commented Jul 22, 2020

closes #69

----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |      100 |      100 |      100 |      100 |                   |
 index.js |      100 |      100 |      100 |      100 |                   |
----------|----------|----------|----------|----------|-------------------|

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@mcollina
Copy link
Member

To say that it "closes #69", you'll need to cover the other branch on line 33. Could you add that as well?

Good work so far!

@mcollina
Copy link
Member

can you add the --100 option to tap in the package.json? It'll validate that the 100% code coverage is maintained.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Amazing work

@mcollina mcollina merged commit f6f3c96 into fastify:master Jul 22, 2020
@Arnovsky Arnovsky deleted the destory-test branch July 22, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

100% code coverage

2 participants