Maybe fix types #73
Maybe fix types #73
Conversation
| @@ -1,4 +1,4 @@ | |||
| import wsPlugin, { SocketStream } from '../..'; | |||
| import * as wsPlugin from '../..'; | |||
There was a problem hiding this comment.
@Ethan-Arrowood @mfpopa @fox1t can you please explain this to me?
There was a problem hiding this comment.
I'll defer to @fox1t as he has a better understanding of this than I do
There was a problem hiding this comment.
I checked out this branch and tested with both esModuleInterop set to true and false (it's false by default). I see find no issues.
There was a problem hiding this comment.
To clarify, when using "esModuleInterop": false (the default), import needs to be done like this import * as wsPlugin from '../..';. When using "esModuleInterop": true, import needs to be done like this import wsPlugin from '../..';.
There was a problem hiding this comment.
It works because export = syntax exports a so called namespace that is then imported by import *. Export default has to be used only in presence of .default prop on the exported object.
|
These changes work for me. I tested with |
|
We need to standardize import checks in our typescript tests. Different packages are exporting types in different ways, even if the JS code is the same. :/ |
|
Yes we should |
5 participants
Fixes #72
@TriangularCube can you please check if this works?