Add update function of video and multi-image #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijufumi
changed the title
ijufumi
commented
Feb 25, 2022
| project is slug of your project. (Required) | ||
| task_name is a task name. (Required) | ||
| project is slug of your project (Required). |
Contributor
Author
There was a problem hiding this comment.
linterで1つのパラメータが1行で収まらないものがあるので、パラメータごとの終わりを認識しやすいように、ピリオドを () の後につけるようにしました。
ijufumi
commented
Feb 25, 2022
| for p in glob.glob( | ||
| os.path.join(dataset_folder_path, "**/*"), recursive=True | ||
| ) | ||
| if re.search(r"/*\.({})".format("|".join(image_types)), str(p)) |
Contributor
Author
There was a problem hiding this comment.
\. がlinterで警告出てたので、 r をつけるようにしました。
ijufumi
commented
Feb 25, 2022
| def find_image_classification_task(self, task_id: str) -> dict: | ||
| """ | ||
| Find a signle image classification task. | ||
| Find a single image classification task. |
Contributor
Author
There was a problem hiding this comment.
気づいたところの typo を修正しました。
ijufumi
commented
Feb 25, 2022
| return self.api.get_request(endpoint) | ||
|
|
||
| def find_image_classification_task_by_name(self, project: str, task_name: str) -> dict: | ||
| def find_image_classification_task_by_name( |
ijufumi
commented
Feb 25, 2022
| ) -> list: | ||
| """ | ||
| Returns a list of image tasks. | ||
| Returns up to 1000 at a time, to get more, set offset as the starting position to fetch. |
Contributor
Author
There was a problem hiding this comment.
maxlength にかかったので、修正しています（他も同様）
ijufumi
commented
Feb 25, 2022
| for p in glob.glob( | ||
| os.path.join(dataset_folder_path, "**/*.txt"), recursive=True | ||
| ) | ||
| if re.search(r"/*\.txt", str(p)) |
Contributor
Author
There was a problem hiding this comment.
\. がlinterで警告出てたので、 r をつけるようにしました。
eisuke-ueta
previously approved these changes
Mar 4, 2022
Contributor
eisuke-ueta
left a comment
eisuke-ueta
left a comment
There was a problem hiding this comment.
LGTM
API側がproductionにマージされたらマージ。
Contributor
|
@eisuke-ueta cc: @ijufumi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応内容
関連Issue
関連PR