Skip to content

Conversation

@takahiro-tamenishi
Copy link
Contributor

README.md Outdated
Comment on lines 751 to 753
dataset slug: image
object name: cat.mp4
split count: 3
Copy link
Contributor

@faycute faycute Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マークダウンがおかしいのと、imageになってるのと、大文字から始めて欲しいのと、見やすくしたいのでこんな感じにしてもらえると!

- Dataset slug: `video`
- Object name: `cat.mp4`
- Split count: `3`

README.md Outdated
Comment on lines 755 to 761
Objects are registered in the data set in the following form.

- video/cat/1.mp4
- video/cat/2.mp4
- video/cat/3.mp4
(omit)
- video/cat/9.mp4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あれ?split count: 3では?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あとomitの部分とか、マークダウンで見るとおかしいので、今後はマークダウンモードで確認してからプルリク上げてもらえると!

@takahiro-tamenishi
Copy link
Contributor Author

readmeを修正しました!

@takahiro-tamenishi
Copy link
Contributor Author

マークダウンモードでも確認しました!

Copy link
Contributor

@ueno-k-work ueno-k-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueno-k-work ueno-k-work merged commit d94f14a into main Sep 15, 2022
@takahiro-tamenishi takahiro-tamenishi deleted the integrate-video branch September 22, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants