Fix POST response control without payload and Base URL can be changed #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuji44
commented
Nov 16, 2022
Comment on lines
+83
to
+84
| elif r.status_code == 204: | ||
| return |
Contributor
Author
There was a problem hiding this comment.
戻りのペイロードがないPOSTレスポンスでAPI側が204を返却するための対策
fuji44
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
戻りのペイロードがないPOSTレスポンスでAPI側が204を返却するための対策と、開発を行いやすくするために、実行時に環境変数でリクエスト先APIを変更できるようにします。
本題とは異なりますが、READMEの記述を修正しています。
テスト