fix: remove annotation type from dataset #161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
編集したファイルについて
主となる編集は
fastlabel/__init__.pyのcreate_datasetメソッドからannotation_type引数を削除した部分のみとなります。テストを実行してみたところ、
get_dataset_objectsの返り値にはobjectSignedUrlがあるのに、create_*_dataset_objectにはなかったためエラーが起きていました。オブジェクトの作成時にもobjectSignedUrlを返すようにAPI側を修正しました。また、
pre-commitのisortでエラーが起きていたのでバージョンを更新しました。(参考)isortのバージョンは python3.7 でも動くように 5.11.5 にしています。