add: license args in create_dataset method #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Jiei-S |
Jiei-S
reviewed
Aug 28, 2023
| ```python | ||
| dataset = client.create_dataset( | ||
| name="object-detection", # Only lowercase alphanumeric characters + hyphen is available | ||
| license="The MIT License" # Optional |
Contributor
There was a problem hiding this comment.
[IMO]
どこかに固定のライセンス一覧を記載しても良さそうです。
（ユーザからすると、何のライセンスがあるか分からない）
※ 公開どドキュメントに記載する場合は不要かも
Contributor
Author
There was a problem hiding this comment.
公開ドキュメントで対応しようと思います。
Contributor
Author
|
@Jiei-S |
Jiei-S
reviewed
Aug 31, 2023
Contributor
Jiei-S
left a comment
Jiei-S
left a comment
There was a problem hiding this comment.
@rikunosuke
コメントしてます
（コード修正不要なら approve します）
| ```python | ||
| dataset = client.create_dataset( | ||
| name="object-detection", # Only lowercase alphanumeric characters + hyphen is available | ||
| license="The MIT License" # Optional |
Contributor
Author
|
@Jiei-S |
Jiei-S
approved these changes
Aug 31, 2023
Contributor
|
application 側に合わせてマージ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
仕様