SDKでリビジョン、バージョンを指定してデータセットを取得できる #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2023 22:00
tsuba-neko
changed the title
anegawa-j
reviewed
Dec 7, 2023
Comment on lines
+3921
to
+3922
| version: str = None, | ||
| revision_id: str = None, |
Contributor
There was a problem hiding this comment.
両方指定されていたらエラーになるのが良いかなと思いましたがいかがでしょうか...?
added 2 commits
December 7, 2023 20:29
anegawa-j
reviewed
Dec 8, 2023
fastlabel/__init__.py
Outdated
| self, | ||
| dataset: str, | ||
| version: str = None, | ||
| tags: List[str] = [], |
Contributor
There was a problem hiding this comment.
Suggested change
| tags: List[str] = [], | |
| tags: List[str] = None, |
pythonにおいて、mutableなオブジェクトをデフォルト引数に与えると、副作用が発生する可能性があるので、Noneを指定して、関数内で tags = tags or [] という形で初期化する形で記述お願いします！
Author
There was a problem hiding this comment.
対応済みです
(非常に勉強になります！！ありがとうございます。)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
SDKでリビジョン、バージョンを指定してデータセットを取得できる
以下PRとセット
https://github.com/fastlabel/fastlabel-application/pull/4794
修正内容
その他仕様など
以下に記載
https://www.notion.so/fastlabel/SDK-578299c30b0f4152a4c41cdea562685e?pvs=4#c7a31ba0789843f58429048dfbb5925b