download と get の引数を同じにする #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| offset: int, | ||
| limit: int, | ||
| version: str, | ||
| revision_id: str, |
Contributor
There was a problem hiding this comment.
@rikunosuke 4016行目でif文でチェックしているということは、ここもOptionalですかね？
Contributor
Author
There was a problem hiding this comment.
@takuya-shimada
Python の Optional[] は None が来る可能性がある、を指しています。型的には str のみを期待して、4016行目は if revision_id != "": を確認している、という意味になります！
| class DatasetObjectGetQuery(TypedDict, total=False): | ||
| dataset: str | ||
| version: str | ||
| revisionId: str |
Contributor
Author
There was a problem hiding this comment.
Python の Optional[] は None が来る可能性がある、を指しています。revisionId は値がある場合は全て str なので、この Optional はつけないが正しいはずです！
Contributor
|
今回の修正と関係ないんですが、 |
takuya-shimada
approved these changes
Jun 12, 2024
Contributor
takuya-shimada
left a comment
takuya-shimada
left a comment
There was a problem hiding this comment.
LGTMです。
（今回の修正と関係ないですが）テストが無いのが不安ですが、一応軽く動作確認しました🌞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応したこと
download_dataset_objects / get_dataset_objects で検索条件が同じになるように修正した。
API側でロジックを統一したため