Add size check of image #95
Merged
+36
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijufumi
commented
Dec 18, 2021
| if not utils.is_video_supported_ext(file_path): | ||
| raise FastLabelInvalidException( | ||
| "Supported extensions are mp4.", 422) | ||
| if os.path.getsize(file_path) > const.SUPPORTED_VIDEO_SIZE: |
Contributor
Author
There was a problem hiding this comment.
拡張子と同じように、utilを作成してチェックするようにしました。
ijufumi
commented
Dec 18, 2021
| # API can accept under 250 MB ( 250 * 1024 * 1024 ) | ||
| SUPPORTED_VIDEO_SIZE = 262144000 | ||
| # API can accept under 250 MB | ||
| SUPPORTED_VIDEO_SIZE = 250 * math.pow(1024, 2) |
Contributor
Author
There was a problem hiding this comment.
math.pow を使って記述した方がわかりやすいと思ったので、変更しました
Contributor
|
@ryoKaz リリース作業しておいてもらえると助かります！ |
Contributor
|
SDKの自動リリース、誰かにGitHubActionsとかで作ってもらっても良さそう。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue