Lower dependency version and delete package-lock.json #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lowers the dependency version of
@fastly/js-computeto^3.0.0and removespackage-lock.json(ornpm-shrinkwrap.json).In a starter kit, we should declare a version of the SDK that has the features needed (^3 in this case), as well as dependencies. And by not including
package-lock.json, the user always gets the newest compatible version at the time their project is initialized, and a new lock file that they would commit to their new project's code repo.For example a new user kicking off with this starter kit today would get
3.8.3because that matches^3.0.0. A person who runs this starter kit next week might get3.9.0if that is available by then, and so on.