Skip to content

fix(fanout): commit request headers before fanout handoff #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2025
Merged

fix(fanout): commit request headers before fanout handoff #1222

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9d62d6
fix(fanout): commit request headers before fanout handoff
harmony7 Nov 10, 2025
ec90760
Merge branch 'main' into kats/fanout-handoff-commit-headers
TartanLlama Nov 13, 2025
1718035
Merge branch 'main' into kats/fanout-handoff-commit-headers
harmony7 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions runtime/fastly/builtins/fastly.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,11 @@ bool Fastly::createFanoutHandoff(JSContext *cx, unsigned argc, JS::Value *vp) {
}
auto grip_upgrade_request = &request_value.toObject();

RootedObject request(cx, grip_upgrade_request);
if (!RequestOrResponse::commit_headers(cx, request)) {
return false;
}

auto response_handle = host_api::HttpResp::make();
if (auto *err = response_handle.to_err()) {
HANDLE_ERROR(cx, *err);
Expand Down
Loading