Merge pull request brianc#256 from booo/jshint

Introduce Jshint

Author: brianc

.jshintrc

@@ -0,0 +1,4 @@
+{
+  "trailing": true,
+  "indent": 2
+}

Makefile

@@ -6,15 +6,16 @@ params := $(connectionString)
 
 node-command := xargs -n 1 -I file node file $(params)
 
-.PHONY : test test-connection test-integration bench test-native build/default/binding.node
+.PHONY : test test-connection test-integration bench test-native \
+	build/default/binding.node jshint
 
 help:
 	@echo "make prepare-test-db [connectionString=pg://<your connection string>]"
 	@echo "make test-all [connectionString=pg://<your connection string>]"
 
 test: test-unit 
 
-test-all: test-unit test-integration test-native test-binary
+test-all: test-unit test-integration test-native test-binary jshint
 
 bench:
 	@find benchmark -name "*-bench.js" | $(node-command)
@@ -50,3 +51,6 @@ prepare-test-db:
 	@echo "***Preparing the database for tests***"
 	@find script/create-test-tables.js  | $(node-command)
 
+jshint:
+	@echo "***Starting jshint***"
+	@./node_modules/.bin/jshint lib

README.md

@@ -115,6 +115,9 @@ I will __happily__ accept your pull request if it:
 - _has tests_
 - looks reasonable
 - does not break backwards compatibility
+- satisfies jshint
+
+Information about the testing processes is in the [wiki](https://github.com/brianc/node-postgres/wiki/Testing).
 
 If you need help or have questions about constructing a pull request I'll be glad to help out as well.
 

lib/arrayParser.js

@@ -28,8 +28,8 @@ ArrayParser.prototype.nextChar = function() {
     };
   }
 };
-ArrayParser.prototype.record = function(char) {
-  return this.recorded.push(char);
+ArrayParser.prototype.record = function(c) {
+  return this.recorded.push(c);
 };
 ArrayParser.prototype.newEntry = function(includeEmpty) {
   var entry;
@@ -47,7 +47,7 @@ ArrayParser.prototype.newEntry = function(includeEmpty) {
 };
 ArrayParser.prototype.parse = function(nested) {
   var c, p, quote;
-  if (nested == null) {
+  if (nested === null) {
     nested = false;
   }
   quote = false;
@@ -89,4 +89,4 @@ module.exports = {
   create: function(source, converter){
     return new ArrayParser(source, converter);
   }
-}
+};