fixed model download handling issue

[duckduckhero]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes update the AI settings view to automatically set the newly downloaded STT or LLM model as the active model in the backend and UI state immediately after download. Additionally, translation files are updated to reflect new source code line references due to these changes, without altering any translation content.

Changes

File(s)	Change Summary
apps/desktop/src/components/settings/views/ai.tsx	Added logic to set the current STT/LLM model in backend and UI state immediately after download.
apps/desktop/src/locales/en/messages.po apps/desktop/src/locales/ko/messages.po	Updated source code line references for translation entries related to AI settings; no string/content changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI (AI Settings)
    participant Backend

    User->>UI (AI Settings): Initiate model download (STT or LLM)
    UI (AI Settings)->>Backend: Download model
    Backend-->>UI (AI Settings): Model download complete
    UI (AI Settings)->>UI (AI Settings): Update selected model state
    UI (AI Settings)->>Backend: Set current model (STT or LLM)
    alt If LLM model
        UI (AI Settings)->>UI (AI Settings): Disable custom LLM endpoint
    end

Loading

Estimated code review effort

2 (~15 minutes)

Possibly related PRs

• Model select hotfix #1185: Also modifies backend model-setting logic and the AI settings component, focusing on syncing frontend and backend state and updating model selection UI to call backend commands on user selection.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d1916a and 76d7cb9.

📒 Files selected for processing (3)

• apps/desktop/src/components/settings/views/ai.tsx (2 hunks)
• apps/desktop/src/locales/en/messages.po (11 hunks)
• apps/desktop/src/locales/ko/messages.po (11 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{js,ts,tsx,rs}

⚙️ CodeRabbit Configuration File

**/*.{js,ts,tsx,rs}: 1. No error handling.
2. No unused imports, variables, or functions.
3. For comments, keep it minimal. It should be about "Why", not "What".

Files:

• apps/desktop/src/components/settings/views/ai.tsx

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: ci (windows, windows-latest)
• GitHub Check: ci (macos, macos-latest)

🔇 Additional comments (4)

apps/desktop/src/components/settings/views/ai.tsx (2)

221-222: LGTM! Automatic STT model activation after download.

The implementation correctly updates both the UI state and backend when an STT model download completes, ensuring the newly downloaded model becomes active without requiring additional user interaction.

---

238-240: LGTM! Comprehensive LLM model activation after download.

The implementation properly handles LLM model activation by:

1. Setting the selected model in UI state
2. Updating the backend with the current model
3. Disabling custom LLM endpoint to ensure the local model is used

This provides a seamless user experience after model downloads.

apps/desktop/src/locales/en/messages.po (1)

349-1202: LGTM! Translation file line reference updates.

The line number references have been correctly updated to reflect the code changes in ai.tsx. This is standard maintenance to keep translation tooling synchronized with the source code after new lines were added.

apps/desktop/src/locales/ko/messages.po (1)

349-1202: LGTM! Korean translation file line reference updates.

The line number references have been correctly updated to match the changes in the source file, maintaining consistency with the English locale updates.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.