-
Notifications
You must be signed in to change notification settings - Fork 433
add react in runtime in og edge function #1716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughTwo configuration and dependency updates: a React import was added to the OG edge function with lint ignore directives, and the dprint formatter configuration was updated to exclude the netlify edge-functions directory from formatting. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/netlify/edge-functions/og.tsx (1)
1-2: Verify whether React import is necessary or if JSX transform can be updated.React 18.2.0 supports the new JSX transform (since React 17), which doesn't require explicit React imports for JSX to work. The
deno-lint-ignore no-unused-varssuggests React isn't actively used in the code—it's only present for JSX syntax.Consider verifying: Is your build configured for the new JSX transform? If so, you can remove the React import and the lint-ignore directive entirely.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/web/netlify/edge-functions/og.tsx(1 hunks)dprint.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: fmt
🔇 Additional comments (1)
dprint.json (1)
34-34: Good call excluding netlify/edge-functions from dprint formatting.This makes sense given that Deno edge-functions may have different linting and formatting requirements than the main codebase, and it aligns well with adding React to the runtime in that directory.
No description provided.