-
Notifications
You must be signed in to change notification settings - Fork 415
Exclude Netlify edge functions from TS compilation #1723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Avoid TypeScript errors from Netlify edge function files by excluding the netlify/edge-functions directory from the apps/web tsconfig include. The edge functions reference remote ESM modules and Deno-specific types that cause "Cannot find module" and implicit any errors during the web project's TypeScript build, so excluding them prevents these spurious compile failures. - Add "netlify/edge-functions/**/*" to tsconfig.json exclude to skip compiling those files. v
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: ./.github/actions/pnpm_install | ||
| - uses: denoland/setup-deno@v2 |
Check failure
Code scanning / zizmor
unpinned action reference Error
| runner: "macos-14" | ||
| runs-on: ${{ matrix.runner }} | ||
| steps: | ||
| - uses: actions/checkout@v4 |
Check warning
Code scanning / zizmor
credential persistence through GitHub Actions artifacts Warning
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughCI scoping narrowed from workspace-wide to focused desktop type checking and testing in desktop workflow. New web-specific CI workflow added with triggered build and test steps. TypeScript configuration for web app updated with refined include and exclude path patterns. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Possibly related PRs
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Avoid TypeScript errors from Netlify edge function files by excluding the netlify/edge-functions directory from the apps/web tsconfig include. The edge functions reference remote ESM modules and Deno-specific types that cause "Cannot find module" and implicit any errors during the web project's TypeScript build, so excluding them prevents these spurious compile failures.
v