Skip to content

Conversation

@yujonglee
Copy link
Contributor

Avoid TypeScript errors from Netlify edge function files by excluding the netlify/edge-functions directory from the apps/web tsconfig include. The edge functions reference remote ESM modules and Deno-specific types that cause "Cannot find module" and implicit any errors during the web project's TypeScript build, so excluding them prevents these spurious compile failures.

  • Add "netlify/edge-functions/**/*" to tsconfig.json exclude to skip compiling those files.
    v

Avoid TypeScript errors from Netlify edge function files by excluding the netlify/edge-functions directory from the apps/web tsconfig include. The edge functions reference remote ESM modules and Deno-specific types that cause "Cannot find module" and implicit any errors during the web project's TypeScript build, so excluding them prevents these spurious compile failures.

- Add "netlify/edge-functions/**/*" to tsconfig.json exclude to skip compiling those files.
v
@netlify
Copy link

netlify bot commented Nov 19, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit 18d6bbd
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/691d0ac82606210009ae8a03
😎 Deploy Preview https://deploy-preview-1723--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

steps:
- uses: actions/checkout@v4
- uses: ./.github/actions/pnpm_install
- uses: denoland/setup-deno@v2

Check failure

Code scanning / zizmor

unpinned action reference Error

unpinned action reference
runner: "macos-14"
runs-on: ${{ matrix.runner }}
steps:
- uses: actions/checkout@v4

Check warning

Code scanning / zizmor

credential persistence through GitHub Actions artifacts Warning

credential persistence through GitHub Actions artifacts
@coderabbitai
Copy link

coderabbitai bot commented Nov 19, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

CI scoping narrowed from workspace-wide to focused desktop type checking and testing in desktop workflow. New web-specific CI workflow added with triggered build and test steps. TypeScript configuration for web app updated with refined include and exclude path patterns.

Changes

Cohort / File(s) Summary
CI workflows — Desktop and Web
.github/workflows/desktop_ci.yaml, .github/workflows/web_ci.yaml
Desktop CI updated to run typecheck and test with -F desktop scope instead of recursive workspace runs (-r). New web CI workflow added with triggers for main branch pushes, PRs, and manual dispatch; includes checkout, pnpm install, Deno setup, and three scoped commands: ui build, web typecheck, and web test.
TypeScript configuration — Web
apps/web/tsconfig.json
Include patterns refined from broad **/*.ts(x) to explicit src/**/*.ts(x) plus specific root-level config files (app.config.ts, content-collections.ts, vite.config.ts). Exclude patterns expanded to cover both **/supabase/functions/**/* and **/netlify/**/*.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Verify that desktop CI scope narrowing (-F desktop) does not unintentionally skip type checking or tests for shared dependencies
  • Confirm new web CI workflow triggers and matrix configuration align with repository branch/path structure and tooling expectations
  • Validate that TypeScript include/exclude path changes in tsconfig.json do not exclude legitimate source files or inadvertently include unnecessary directories

Possibly related PRs

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch yl-branch-20-3

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56f77fe and 18d6bbd.

📒 Files selected for processing (3)
  • .github/workflows/desktop_ci.yaml (1 hunks)
  • .github/workflows/web_ci.yaml (1 hunks)
  • apps/web/tsconfig.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yujonglee yujonglee merged commit 7140860 into main Nov 19, 2025
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants