-
Notifications
You must be signed in to change notification settings - Fork 415
Add seperate window for devtool #1727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a header with tauri drag region to prevent the traffic light controls from covering content and enable window dragging. Move padding and content into a scrollable main area (div with overflow-y-auto and p-4) and reorganize component order so TinyTickMonitor, SeedList and NavigationList live inside the scrollable region. Also remove the extra padding on the root container to ensure header aligns correctly.
Center title in devtool header and simplify label
The devtool header title was not properly centered and the label also read "Hyprnote Devtool". Wrap the title in a flex container to center it horizontally and remove the extra justification class. Also simplify the visible label to "Devtool" and keep the tauri drag region on the span. This improves header alignment and shortens the title for clarity.
wip
v
Add devtool route, UI trigger, and window type
Introduce a developer tools (devtool) route and UI entry to help with debugging and seeding app state during development. This adds a new /app/devtool route and component (seed list, navigation helpers, TinyTick monitor), exposes a window type "devtool" in the windows plugin, and wires a small AxeIcon button in the desktop sidebar (DEV-only) to open the devtool window.
Changes:
- Add apps/desktop/src/routes/app/devtool.tsx implementing the devtool UI, window-driven navigation helpers, and a global window.__dev API for running seeds.
- Add a DEV-only AxeIcon button to apps/desktop/src/components/main/sidebar/index.tsx that triggers windowsCommands.windowShow({ type: 'devtool' }).
- Export windows commands/events usage in desktop routes and remove unused Suspense/devtool wrapper logic.
- Extend plugins/windows/src/window/v1.rs to include a Devtool AppWindow variant and implement window creation behavior (size tweaks, always_on_top for devtool).
This is needed to provide an in-app developer tool for quick state seeding and navigation during development without changing production behavior.
v
v
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe PR restructures the devtool system from a globally-managed overlay component into a route-based window, updates relative import paths across seed modules (3-level to 4-level), integrates devtool window support into the plugin system, adds a sidebar button to launch the devtool, and removes the old devtool UI module. Changes
Sequence DiagramsequenceDiagram
participant User
participant Sidebar as Sidebar Button
participant WindowsCmd as Windows Commands
participant Route as /app/devtool Route
participant Devtool as Devtool Component
participant Store as Persisted Store
User->>Sidebar: Click DEV button (DEV mode only)
Sidebar->>WindowsCmd: windowShow({ type: "devtool" })
WindowsCmd->>Route: Navigate to /app/devtool
Route->>Devtool: Render devtool UI
Devtool->>Store: Access persisted store
Devtool->>Devtool: Wire window.__dev API
User->>Devtool: Select and run seed
Devtool->>Store: seed.run(persistedStore)
Devtool-->>User: Display result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Areas requiring extra attention:
Possibly related PRs
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (25)
💤 Files with no reviewable changes (1)
🧰 Additional context used🧬 Code graph analysis (3)plugins/windows/src/window/v1.rs (1)
apps/desktop/src/components/devtool/seed/shared/chat.ts (2)
apps/desktop/src/routes/app/devtool.tsx (4)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (28)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No description provided.