feat: add crates/version for shared semver utilities#3409
Merged
Conversation
- Create crates/version with version comparison utilities (is_at_least, is_before, is_in_range, is_in_range_inclusive) - Re-export semver::Version for convenience - Update plugins/fs-db to use hypr-version instead of semver directly - Add comprehensive tests for version comparison functions Co-Authored-By: yujonglee <yujonglee.dev@gmail.com>
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
❌ Deploy Preview for howto-fix-macos-audio-selection failed.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates a new
crates/versioncrate to centralize semver utilities that can be shared across plugins. This is the first step toward enabling version-based feature gating inplugins/flag(which will be added in a follow-up).The new crate provides:
semver::Versionfor convenienceis_at_least,is_before,is_in_range,is_in_range_inclusiveUpdates
plugins/fs-dbto usehypr-versioninstead of depending onsemverdirectly.Review & Testing Checklist for Human
bindings.gen.tschanges are expected - The regenerated file removedPingRequest,PingResponsetypes and thepingcommand. Confirm this removal is intentional and not a regression.thiserrordependency incrates/version/Cargo.tomlis needed (it appears unused in the current implementation)cargo test -p versionandcargo test -p tauri-plugin-fs-dbto verify tests passNotes
This PR sets up the foundation for version-based feature flags in
plugins/flagas discussed. The actual integration withplugins/flagwill come in a follow-up PR.Link to Devin run: https://app.devin.ai/sessions/c9a0c464b8424e729737fb6133cc52c1
Requested by: @yujonglee