feat(notification): Spawn event notification in a separate task

[ComputelessComputer]

What was happening

1. Tauri’s plugin::Builder::setup() executes inside the app-wide Tokio runtime that Tauri starts for you.
2. Our code tried to run an async helper inside that setup by doing

tokio::runtime::Handle::current().block_on(app.start_event_notification())

3. Handle::current().block_on() starts a second runtime and blocks the current thread until the future finishes. Tokio forbids nesting a runtime inside another running runtime – it would dead-lock the executor.
4. Tokio therefore panicked with Cannot start a runtime from within a runtime, aborting the process during startup for any user who had Event Notifications enabled.

Why the patch fixes it

let app_handle = app.clone();
tauri::async_runtime::spawn(async move {
    if let Err(e) = app_handle.start_event_notification().await { … }
});

• tauri::async_runtime::spawn schedules the future on the existing executor instead of blocking.
• No secondary runtime is created, so Tokio’s nesting guard is happy.
• Startup continues; if start_event_notification fails we just log the error instead of panicking.

Summary by CodeRabbit

• Refactor
  • Improved event notification initialization to run asynchronously in the background, enhancing app responsiveness during setup.

[coderabbitai]

Walkthrough

The event notification initialization logic was updated from a synchronous, blocking approach to an asynchronous, non-blocking model. The code now spawns a background task to handle event notification startup, allowing setup to proceed without waiting for completion. Error logging is performed within the spawned task.

Changes

File(s)	Change Summary
plugins/notification/src/lib.rs	Refactored event notification startup from synchronous blocking to asynchronous task spawning.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant NotificationPlugin
    participant AsyncTask

    App->>NotificationPlugin: Initialize plugin
    NotificationPlugin->>AsyncTask: Spawn async task for event notification
    AsyncTask->>NotificationPlugin: Await start_event_notification()
    AsyncTask->>AsyncTask: Log errors if any

Loading

Poem

A rabbit hops, no longer waits,
Async winds now open gates.
Tasks are spawned, the thread runs free,
Notifications start with glee.
In the meadow, logs still bloom—
Async joy in every room!
🐇✨

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

---

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 59b1a6d and 16f07fd.

📒 Files selected for processing (1)

• plugins/notification/src/lib.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: ci (windows, windows-latest)
• GitHub Check: ci (macos, macos-latest)

🔇 Additional comments (1)

plugins/notification/src/lib.rs (1)

59-64: Good fix for the nested runtime panic issue!

This change correctly addresses the issue described in the PR objectives. By using tauri::async_runtime::spawn instead of blocking with block_on(), you avoid creating a nested Tokio runtime that would cause a panic.

The implementation:

1. Clones the app handle to safely move it into the async closure
2. Spawns a task on the existing Tokio runtime
3. Properly awaits the event notification initialization
4. Maintains error logging in case of failures

This approach follows best practices for asynchronous Rust and allows the application to continue starting up even if event notification initialization encounters issues.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ComputelessComputer]

@yujonglee I think this might fix #870 . Could you take a look into this?