Swap event and detect notification settings

[ComputelessComputer]

This change swaps the behavior of the event and detect notification settings. Previously, the "event" setting controlled whether notifications were shown for events, and the "detect" setting controlled whether notifications were shown for detected changes. This has been reversed, so that the “event" setting now controls detected changes, and the "detect" setting controls events.

Summary by CodeRabbit

• Bug Fixes
  • Corrected notification settings so that changes to event and detect notifications now update the appropriate notification type, ensuring accurate behavior when modifying notification preferences.

[coderabbitai]

Walkthrough

The update corrects the notification command functions and mutation logic in the notifications settings component. It ensures that event notification mutations use event-specific commands and values, while detect notification mutations use detect-specific counterparts. The refetched queries on mutation success are also aligned with the appropriate notification type.

Changes

File	Change Summary
apps/desktop/src/components/settings/views/notifications.tsx	Corrected notification command functions and mutation logic to match the appropriate notification type (event or detect).

Poem

A bunny hopped through code so neat,
Swapping "event" for "detect" in a tidy feat.
Now notifications know their place,
Each mutation in the proper space.
With every hop, the logic's right—
Settings shine, bugs take flight!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7055bb and c597d0f.

📒 Files selected for processing (1)

• apps/desktop/src/components/settings/views/notifications.tsx (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: ci (macos, macos-latest)
• GitHub Check: ci (windows, windows-latest)

🔇 Additional comments (4)

apps/desktop/src/components/settings/views/notifications.tsx (4)

42-57: LGTM! Event mutation now correctly uses event-specific commands.

The changes properly align the event mutation logic with event-specific notification commands. Previously, this mutation appears to have been using detect-related commands, which would have caused incorrect behavior.

The changes ensure:

• setEventNotification() is used instead of detect equivalent
• v.event is returned instead of v.detect
• eventNotification.refetch() is called for proper cache invalidation
• startEventNotification() and stopEventNotification() are used for lifecycle management

---

63-78: LGTM! Detect mutation now correctly uses detect-specific commands.

The changes properly align the detect mutation logic with detect-specific notification commands. This fixes the previous misalignment where event-related commands were being used.

The changes ensure:

• setDetectNotification() is used for the correct notification type
• v.detect is returned matching the mutation purpose
• detectNotification.refetch() ensures proper cache invalidation
• startDetectNotification() and stopDetectNotification() handle the correct lifecycle

---

124-150:

✅ Verification successful

Verify UI label alignment with backend behavior.

The "event" field is labeled "Upcoming meeting notifications" with description about calendar meetings starting soon. Ensure this matches the actual behavior of event notification commands.

---

🏁 Script executed:

#!/bin/bash
# Description: Verify the behavior of event notification commands to ensure UI labels are accurate
# Expected: Find event notification command implementations or documentation

# Search for event notification command implementations  
ast-grep --pattern 'function setEventNotification($_) { $$$ }'
ast-grep --pattern 'function startEventNotification($_) { $$$ }'
ast-grep --pattern 'function getEventNotification($_) { $$$ }'

# Search for event notification related code and comments
rg -A 5 -B 5 "EventNotification|event.*notification" --type ts --type js

Length of output: 25705

---

UI labels correctly reflect the event notification behavior.

The event toggle maps directly to getEventNotification/setEventNotification and to starting/stopping scheduled “upcoming meeting” alerts. The locale entries

• “(Beta) Upcoming meeting notifications”
• “Show notifications when you have meetings starting soon in your calendar.”

match the plugin’s implementation of event notifications. No changes required.

---

98-123:

✅ Verification successful

Verify UI label alignment with backend behavior.

The "detect" field is labeled "Detect meetings automatically" with description "Show notifications when you join a meeting." Ensure this aligns with what the detect notification commands actually do in the backend.

---

🏁 Script executed:

#!/bin/bash
# Description: Verify the behavior of detect notification commands to ensure UI labels are accurate
# Expected: Find detect notification command implementations or documentation

# Search for detect notification command implementations
ast-grep --pattern 'function setDetectNotification($_) { $$$ }'
ast-grep --pattern 'function startDetectNotification($_) { $$$ }'
ast-grep --pattern 'function getDetectNotification($_) { $$$ }'

# Search for detect notification related code and comments
rg -A 5 -B 5 "DetectNotification|detect.*notification" --type ts --type js

Length of output: 5883

---

UI label correctly reflects backend behavior

I’ve confirmed that toggling the “Detect meetings automatically” switch calls setDetectNotification and startDetectNotification/stopDetectNotification under the hood, matching the description “Show notifications when you join a meeting.” No changes needed here.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.