Skip to content

Add SimpleCov even without an environment variable #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add SimpleCov even without an environment variable #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bd5df54
Add SimpleCov even without an environment variable
etagwerker Jan 26, 2020
3bde250
Add artifacts configuration
etagwerker Feb 4, 2020
ec7c3a9
Make sure that we run skunk on `app`
etagwerker Feb 4, 2020
0ee6281
Debug artifacts upload
etagwerker Feb 6, 2020
6d5389f
Correct configuration
etagwerker Feb 6, 2020
07dfd04
Update configuration
etagwerker Feb 6, 2020
a39824e
Add skunk steps after RSpec executes
etagwerker Feb 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/skunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# .github/workflows/skunk.yml

name: Skunk
on: [push, pull_request]

jobs:
skunk:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v1
- name: Setup Ruby
uses: actions/setup-ruby@v1
with:
ruby-version: 2.6.x
- name: Run Skunk on Project
run: |
gem install skunk
skunk app
13 changes: 11 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,21 @@ branches:

env:
global:
- AWS_ACCESS_KEY_ID=${ARTIFACTS_KEY}
- AWS_SECRET_ACCESS_KEY=${ARTIFACTS_SECRET}
- TRAVIS_NODE_VERSION="10"
- DISCOURSE_HOSTNAME=www.example.com
- RUBY_GLOBAL_METHOD_CACHE_SIZE=131072
matrix:
- "RAILS_MASTER=0 QUNIT_RUN=0 RUN_LINT=0"
- "RAILS_MASTER=0 QUNIT_RUN=1 RUN_LINT=0"
- "RAILS_MASTER=0 QUNIT_RUN=0 RUN_LINT=1"

addons:
artifacts:
bucket: ombulabs-discourse-test
paths:
- ./coverage
target_paths: $TRAVIS_BUILD_NUMBER
debug: true
chrome: stable
postgresql: "9.6"
apt:
Expand Down Expand Up @@ -82,5 +88,8 @@ script:
else
bundle exec rspec && bundle exec rake plugin:spec
fi
gem install skunk
cat coverage/.resultset.json
skunk app
fi
"
6 changes: 2 additions & 4 deletions spec/rails_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
# frozen_string_literal: true

if ENV['COVERAGE']
require 'simplecov'
SimpleCov.start
end
require 'simplecov'
SimpleCov.start

require 'rubygems'
require 'rbtrace'
Expand Down