Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
matrix:
os: [ubuntu]
ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3"]
ruby-version: ["2.6", "2.7", "3.0", "3.1", "3.2", "3.3", "3.4"]
steps:
- uses: actions/checkout@v2
- name: Setup Ruby ${{ matrix.ruby-version }}
Expand All @@ -19,6 +19,6 @@ jobs:
bundler-cache: true
- name: Build and run tests
run: |
gem install bundler -v 2.4.6
gem install bundler -v 2.4.22
bundle install --jobs 4 --retry 3
bundle exec rake
4 changes: 2 additions & 2 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2025-10-09 00:04:06 UTC using RuboCop version 1.81.1.
# on 2025-10-17 11:20:00 UTC using RuboCop version 1.81.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -40,7 +40,7 @@ Metrics/AbcSize:
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
# AllowedMethods: refine
Metrics/BlockLength:
Max: 79
Max: 82

# Offense count: 2
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

* [FEATURE: Add Skunk HTML Report](https://github.com/fastruby/skunk/pull/123)
* [FEATURE: Add Skunk::Config class](https://github.com/fastruby/skunk/pull/123)
* [FEATURE: Add Ruby 3.4 compatibility](https://github.com/fastruby/skunk/pull/124)

## v0.5.4 / 2025-05-05 [(commits)](https://github.com/fastruby/skunk/compare/v0.5.3...v0.5.4)

Expand Down
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ gemspec

gem "reek", "~> 6.1"
gem "rubocop", "~> 1.48"
gem "vcr", "~> 6.1.0"
2 changes: 1 addition & 1 deletion skunk.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -52,5 +52,5 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rubocop"
spec.add_development_dependency "simplecov", "~> 0.18"
spec.add_development_dependency "simplecov-console", "0.5.0"
spec.add_development_dependency "webmock", "~> 3.10.0"
spec.add_development_dependency "webmock", "~> 3.20.0"
end
9 changes: 6 additions & 3 deletions test/lib/skunk/application_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,12 @@
end

around do |example|
VCR.use_cassette "skunk-fyi" do
example.call
end
stub_request(:post, "https://skunk.fastruby.io/reports").to_return(
status: 200,
body: '{"id":"j"}',
headers: { "Content-Type" => "application/json" }
)
example.call
end

it "share report to default server" do
Expand Down
59 changes: 0 additions & 59 deletions test/samples/vcr/skunk-fyi.yml

This file was deleted.

7 changes: 0 additions & 7 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
require "minitest/around/spec"
require "minitest/stub_any_instance"
require "webmock/minitest"
require "vcr"

require "skunk/rubycritic/analysed_module"

Expand All @@ -52,9 +51,3 @@ def capture_output_streams
$stdout = STDOUT
$stderr = STDERR
end

VCR.configure do |config|
config.hook_into :webmock
config.allow_http_connections_when_no_cassette = false
config.cassette_library_dir = "test/samples/vcr"
end