feat(ui): add quota fields to grant creation form#49
Merged
Conversation
Add Max Queries and Max Data Transfer fields to the Create Grant dialog, allowing administrators to set usage limits when granting database access. The grant list now displays both query count and bytes transferred usage. Changes: - Add formatBytes helper for human-readable byte formatting - Add Max Queries input field with "Unlimited" placeholder - Add Max Data Transfer input with MB/GB unit selector - Update Usage column to show queries and bytes transferred - Add 5 Playwright E2E tests for quota functionality - Fix E2E test port conflict (5432 → 5434) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
fclairamb
force-pushed
the
feat/grant-quota-ui
branch
from
a017b4a to
f579da1
Compare
- Change default expiration from 30 days to 2 hours - Display duration between effective start (max of now, start_time) and expiration - Add validation that expiration must be after start time - Show error message and disable submit when validation fails Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Screenshots
Create Grant Dialog
Shows quota fields (Max Queries, Max Data Transfer with MB/GB selector) and duration display:
Grant List with Usage
Shows the Usage column with queries count and bytes transferred:
🤖 Generated with Claude Code