Returning 502 on REIN #473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472
Adds the REIN command, and returns a 502 status when it is received. This behaviour matches VSFTPD, and clients seem to choke when getting a 500 on a technically valid command.
EDIT: Have also added the NotImplemented handler for other standard commands that have not been implemented. We'd want to send a 502 for any commands that are actually standardised but not implemented, none of these would be syntax errors (500) by default.