Skip to content

Conversation

@KirCute
Copy link
Contributor

@KirCute KirCute commented Feb 27, 2025

Allow the caller to customize SITE command.

@fclairamb
Copy link
Owner

Sorry for the late answer. I'm not too sure about this implementation. Wouldn't it make more sense to make it an interface like everywhere else where we extend the features of the library ?

What do you think @drakkan ?

@codecov
Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.44%. Comparing base (6e2547d) to head (87d540e).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
handle_misc.go 72.72% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
- Coverage   86.68%   86.44%   -0.25%     
==========================================
  Files          11       11              
  Lines        2328     2338      +10     
==========================================
+ Hits         2018     2021       +3     
- Misses        236      242       +6     
- Partials       74       75       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fclairamb
Copy link
Owner

Hi @KirCute what do you think about this implementation #544 ?

fclairamb added a commit that referenced this pull request Jun 11, 2025
@KirCute
Copy link
Contributor Author

KirCute commented Jun 12, 2025

Hi @KirCute what do you think about this implementation #544 ?

I think it's quite good. It looks like more flexible.

@KirCute KirCute closed this Jun 12, 2025
@KirCute KirCute deleted the feat/custom-site branch June 14, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants