Bug fixes #440
Merged
Bug fixes #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caelunshun
reviewed
Jun 28, 2021
feather/server/src/lib.rs
Outdated
| let mut clients = Vec::new(); | ||
| for player in self.new_players.clone().try_iter() { | ||
| if let Some(cl) = self.clients.iter().find(|x| x.uuid() == player.uuid) { | ||
| cl.disconnect("Logged in from another location!"); |
There was a problem hiding this comment.
Looks like we need to return here, or else the new client gets added anyway.
There was a problem hiding this comment.
We are not removing the new client but instead the old one. Thus returning would probably just break everything.
feather/server/src/systems/view.rs
Outdated
| position, | ||
| &mut server.waiting_chunks, | ||
| )?; | ||
| // As each iteration takes a while, it can happen that a player |
There was a problem hiding this comment.
The cause of the problem isn't actually clients being removed while the loop is running, since the client list is only accessible by one thread. It happens because players in the ECS aren't removed for one extra tick after they disconnect (so plugins can handle disconnect events), and as a result, the query finds dead clients.
The solution here still works, but the comment should be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes
Status
Description
pull_request_template.mdinCONTRIBUTING.mdRelated issues
#411 #418 #435
Checklist
cargo fmt,cargo clippy,cargo build --releaseandcargo testand fixed any generated errors!