Skip to content

Test Runner failed in case of invalid Semver version issue fixes #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Test Runner failed in case of invalid Semver version issue fixes #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/kotlin/com/featurevisor/sdk/Conditions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ object Conditions {
}

private fun compareVersions(actual: String, condition: String): Int {
return SemVer.parse(actual).compareTo(SemVer.parse(condition))
return try {
SemVer.parse(actual).compareTo(SemVer.parse(condition))
} catch (e: Exception) {
0
}
}
}
6 changes: 2 additions & 4 deletions src/main/kotlin/com/featurevisor/sdk/Instance+Evaluation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,9 @@ fun FeaturevisorInstance.evaluateVariation(featureKey: FeatureKey, context: Cont
evaluation = Evaluation(
featureKey = featureKey,
reason = ERROR,
error(e)
)

this.logger?.error("error", evaluation.toDictionary())
this.logger?.error(message = e.message.orEmpty(), details = evaluation.toDictionary())

return evaluation
}
Expand Down Expand Up @@ -433,10 +432,9 @@ fun FeaturevisorInstance.evaluateFlag(featureKey: FeatureKey, context: Context =
evaluation = Evaluation(
featureKey = featureKey,
reason = ERROR,
error(e)
)

this.logger?.error("error", evaluation.toDictionary())
this.logger?.error(message = e.message.orEmpty(), details = evaluation.toDictionary())

return evaluation
}
Expand Down
2 changes: 1 addition & 1 deletion src/main/kotlin/com/featurevisor/testRunner/TestExecuter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ fun startTest(option: TestProjectOption) {
try {
executionResult = executeTest(filePath, dataFile = datafile, option)
} catch (e: Exception) {
printMessageInRedColor("Exception in $filePath --> ${e.message}")
printMessageInRedColor("Exception while execution test --> ${e.message}")
}

if (executionResult == null) {
Expand Down