Skip to content

Conversation

@stayallive
Copy link
Contributor

@stayallive stayallive commented Sep 4, 2019

It would be greatly appreciated to have an Laravel 6 release tagged so we can use this package with Laravel 6. There are however some unrelated commits in here to fix the test suite. If you don't want those feel free to only get the composer.json changes from here 👍

@stayallive stayallive marked this pull request as ready for review September 4, 2019 19:32
@juukie
Copy link
Contributor

juukie commented Sep 5, 2019

Thanks @stayallive 👍

@juukie
Copy link
Contributor

juukie commented Sep 5, 2019

@stayallive the readme.md also contains 'This package needs Laravel 5.x'. You could add 6.x as well.

@stayallive stayallive mentioned this pull request Sep 6, 2019
@juukie
Copy link
Contributor

juukie commented Sep 10, 2019

@fedeisas could you please merge @stayallive's PR?

@fedeisas fedeisas merged commit 2f62621 into fedeisas:master Sep 13, 2019
@juukie
Copy link
Contributor

juukie commented Sep 14, 2019

Thank you @fedeisas :-)

@Vinze
Copy link

Vinze commented Sep 16, 2019

Still not working here.. Am I doing something wrong?

Fresh Laravel 6.0.3 install, and only did a composer require fedeisas/laravel-mail-css-inliner.

Using version ^2.2 for fedeisas/laravel-mail-css-inliner
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for fedeisas/laravel-mail-css-inliner ^2.2 -> satisfiable by fedeisas/laravel-mail-css-inliner[2.2].
    - Conclusion: remove laravel/framework v6.0.3
    - Conclusion: don't install laravel/framework v6.0.3
    - fedeisas/laravel-mail-css-inliner 2.2 requires illuminate/support ~5.0 -> satisfiable by illuminate/support[5.0.x-dev, 5.1.x-dev, 5.2.x-dev, 5.3.x-dev, 5.4.x-dev, 5.5.x-dev, 5.6.x-dev, 5.7.17, 5.7.18, 5.7.19, 5.7.x-dev, 5.8.x-dev, v5.0.0, v5.0.22, v5.0.25, v5.0.26, v5.0.28, v5.0.33, v5.0.4, v5.1.1, v5.1.13, v5.1.16, v5.1.2, v5.1.20, v5.1.22, v5.1.25, v5.1.28, v5.1.30, v5.1.31, v5.1.41, v5.1.6, v5.1.8, v5.2.0, v5.2.19, v5.2.21, v5.2.24, v5.2.25, v5.2.26, v5.2.27, v5.2.28, v5.2.31, v5.2.32, v5.2.37, v5.2.43, v5.2.45, v5.2.6, v5.2.7, v5.3.0, v5.3.16, v5.3.23, v5.3.4, v5.4.0, v5.4.13, v5.4.17, v5.4.19, v5.4.27, v5.4.36, v5.4.9, v5.5.0, v5.5.16, v5.5.17, v5.5.2, v5.5.28, v5.5.33, v5.5.34, v5.5.35, v5.5.36, v5.5.37, v5.5.39, v5.5.40, v5.5.41, v5.5.43, v5.5.44, v5.6.0, v5.6.1, v5.6.10, v5.6.11, v5.6.12, v5.6.13, v5.6.14, v5.6.15, v5.6.16, v5.6.17, v5.6.19, v5.6.2, v5.6.20, v5.6.21, v5.6.22, v5.6.23, v5.6.24, v5.6.25, v5.6.26, v5.6.27, v5.6.28, v5.6.29, v5.6.3, v5.6.30, v5.6.31, v5.6.32, v5.6.33, v5.6.34, v5.6.35, v5.6.36, v5.6.37, v5.6.38, v5.6.39, v5.6.4, v5.6.5, v5.6.6, v5.6.7, v5.6.8, v5.6.9, v5.7.0, v5.7.1, v5.7.10, v5.7.11, v5.7.15, v5.7.2, v5.7.20, v5.7.21, v5.7.22, v5.7.23, v5.7.26, v5.7.27, v5.7.28, v5.7.3, v5.7.4, v5.7.5, v5.7.6, v5.7.7, v5.7.8, v5.7.9, v5.8.0, v5.8.11, v5.8.12, v5.8.14, v5.8.15, v5.8.17, v5.8.18, v5.8.19, v5.8.2, v5.8.20, v5.8.22, v5.8.24, v5.8.27, v5.8.28, v5.8.29, v5.8.3, v5.8.30, v5.8.31, v5.8.32, v5.8.33, v5.8.34, v5.8.35, v5.8.4, v5.8.8, v5.8.9].
    - don't install illuminate/support 5.5.x-dev|don't install laravel/framework v6.0.3

@stayallive
Copy link
Contributor Author

Looks like it was merged but not tagged yet.

For now change ^2.2 in dev-master@dev to install.

@fedeisas it would be really appreciated if you could find the time to tag a release 👍 thanks in advance!

@stayallive stayallive deleted the laravel-6-support branch September 16, 2019 13:38
@winkbrace
Copy link
Contributor

@fedeisas Is there something preventing you from tagging that I can help you with?

@fedeisas
Copy link
Owner

fedeisas commented Oct 2, 2019

@winkbrace is this ok https://github.com/fedeisas/laravel-mail-css-inliner/releases/tag/2.3?

@winkbrace
Copy link
Contributor

Hahaha that's perfect <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants