No completion outside of function

[mniewrzal]

Example:

<?php
$abc = 1;
$abc2 = 2;
echo $ab

[felixfbecker]

This only happens when there is no function node around the variable, it is not related to the semicolon (there are tests for that)

[cweagans]

I started looking into this. Here's what I had:

diff --git a/fixtures/completion/bare_php.php b/fixtures/completion/bare_php.php
new file mode 100644
index 0000000..36b5ad9
--- /dev/null
+++ b/fixtures/completion/bare_php.php
@@ -0,0 +1,5 @@
+<?php
+
+$abc = 1;
+$abc2 = 2;
+echo $ab
diff --git a/tests/Server/TextDocument/CompletionTest.php b/tests/Server/TextDocument/CompletionTest.php
index 15349ed..3512113 100644
--- a/tests/Server/TextDocument/CompletionTest.php
+++ b/tests/Server/TextDocument/CompletionTest.php
@@ -433,4 +433,35 @@ class CompletionTest extends TestCase
             )
         ], true), $items);
     }
+
+    public function testBarePhp()
+    {
+        $completionUri = pathToUri(__DIR__ . '/../../../fixtures/completion/bare_php.php');
+        $this->loader->open($completionUri, file_get_contents($completionUri));
+        $items = $this->textDocument->completion(
+            new TextDocumentIdentifier($completionUri),
+            new Position(5, 8)
+        )->wait();
+        $this->assertEquals(new CompletionList([
+            new CompletionItem(
+                '$abc',
+                CompletionItemKind::VARIABLE,
+                null,
+                null,
+                null,
+                null,
+                '$abc'
+            ),
+            new CompletionItem(
+                '$abc2',
+                CompletionItemKind::VARIABLE,
+                null,
+                null,
+                null,
+                null,
+                '$abc2'
+            ),
+        ], true), $items);
+    }
+
 }

I started debugging, but I'm out of time to spend on this for today, but here's the gist of what I found:

$doc that's passed to CompletionProvider::provideCompletion() when this test is run is incomplete - it only contains AST nodes for the variable assignments, so $doc->getNodeAtPosition() returns NULL for the position at the end of the last line. I'm wondering if there's something weird going on with the parser because the last line is invalid PHP syntax.

[felixfbecker]

If that is the case, this is a bug in the parser. In any case, feel free to open a PR, that unit test is valuable

[cweagans]

Happy to do so. Just wasn't sure if you wanted a failing test or not.

[nikic]

This should now be fixed in PHP-Parser. Please test :)

[felixfbecker]

@nikic just tested with v3.0.3.
This is the AST with the code snippet in the original post:

The echo statement is missing

[nikic]

The change isn't in v3.03, can you try 3.0-dev?

[felixfbecker]

@nikic works. Please ping me when you release it :)