Make Index an EventEmitter #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.59% (diff: 95.65%)@@ master #255 diff @@
==========================================
Files 49 51 +2
Lines 1251 1412 +161
Methods 132 152 +20
Messages 0 0
Branches 0 0
==========================================
+ Hits 1094 1251 +157
- Misses 157 161 +4
Partials 0 0
|
eseliger
reviewed
Jan 24, 2017
| * @return void | ||
| */ | ||
| public function setStaticComplete() | ||
| { |
eseliger
reviewed
Jan 24, 2017
src/Server/Workspace.php
Outdated
| $symbols[] = $definition->symbolInformation; | ||
| return coroutine(function () use ($query) { | ||
| // Wait until indexing for definitions finished | ||
| if (!$this->index->isComplete()) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #239
This changes the whole indexing process to be async again. The
Indexis now anEventEmitterthat emits two events:definition-addedwhen a Definition was addedcompletewhen the indexing has completed (triggered throughsetComplete())isCompete()returns the current status.All methods that return multiple results that depend on the project index (
workspace/symbols,textDocument/references,workspace/xreferences) now defer the response until indexing finished.All methods that need to resolve a single definition (
textDocument/(x)definition,textDocument/hover) check the index for a result, then if no result was found and indexing did not finish yet, check again on every added definition.Since
LanguageServer::indexis now executed async, adds newbeforeIndexhook.