Automatically index stubs on composer install #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
approved these changes
Feb 2, 2017
Codecov Report@@ Coverage Diff @@
## master #269 +/- ##
==========================================
Coverage 88.59% 88.59%
- Complexity 0 703 +703
==========================================
Files 51 51
Lines 1412 1412
==========================================
Hits 1251 1251
Misses 161 161Continue to review full report at Codecov.
|
felixfbecker
reviewed
Feb 2, 2017
Owner
felixfbecker
left a comment
felixfbecker
left a comment
There was a problem hiding this comment.
If this works, why didn't Travis parse the stubs twice now?
Contributor
Author
|
I have no idea. It works locally. Might be an issue with Travis' composer version or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will only run automatically when a developer runs composer install - this is not run for anyone that gets this package as a requirement of some other package (so projects that require the language server will still have to manually index the stubs).