Fix missing '()' for function definition #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
=========================================
Coverage 84.18% 84.18%
Complexity 812 812
=========================================
Files 59 59
Lines 1720 1720
=========================================
Hits 1448 1448
Misses 272 272
Continue to review full report at Codecov.
|
felixfbecker
requested changes
Apr 1, 2017
src/DefinitionResolver.php
Outdated
| return new Types\Mixed; | ||
| } | ||
| $fqn = (string)($expr->getAttribute('namespacedName') ?? $expr->name); | ||
| $fqn = (string)($expr->getAttribute('namespacedName') ?? $expr->name . '()'); |
Owner
There was a problem hiding this comment.
Pretty sure namespacedName would need to get the () too, so you have to move the parenthesis
Contributor
Author
There was a problem hiding this comment.
Yeah, you're right. I have made wrong assumption as to what namespacedName actually contains.
felixfbecker
approved these changes
Apr 1, 2017
Owner
|
Thanks for getting to the bottom of this! |
lialan
pushed a commit
to lambdalab/php-language-server
that referenced
this pull request
Apr 30, 2017
zfy0701
pushed a commit
to lambdalab/php-language-server
that referenced
this pull request
May 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix:
#311
#325
#326