Seamless Custodian Switch #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zajck
reviewed
Jan 7, 2025
| ) internal { | ||
| // Check the caller is the new custodian's assistant | ||
| address msgSender = _msgSender(); | ||
| uint256 newCustodianId = EntityLib.getOrCreateBuyerId(msgSender, _pl); |
There was a problem hiding this comment.
This is slightly non-intended way of using getOrCreateBuyerId. But, ok, you can keep it this way, since in #317 I replaced getOrCreateBuyerId with a more generic getOrCreateEntityId
contracts/contracts/protocol/libs/EntityLib.sol
Lines 331 to 343 in c59ca4b
I suggest you either add TODO comment to replace this once #317 is merged or checkout this change from there and use it here.
|
@zajck I have addressed all your comments and made a major refactor of the implementation. Please re-review at your own convenience. |
zajck
reviewed
Jan 13, 2025
0xlucian
changed the title
zajck
requested changes
Jan 17, 2025
zajck
requested changes
Mar 3, 2025
| function requestCustodianUpdate( | ||
| uint256 _offerId, | ||
| uint256 _newCustodianId, | ||
| FermionTypes.CustodianFee calldata _newCustodianFee, |
There was a problem hiding this comment.
In line with #394 please also add here a check to revert if _newCustodianFee.period == 0.
zajck
requested changes
Mar 6, 2025
Co-authored-by: Klemen <64400885+zajck@users.noreply.github.com>
zajck
approved these changes
Mar 6, 2025
zajck
added a commit
that referenced
this pull request
Mar 12, 2025
levalleux-ludo
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #209