fix: show real build commit and version#1862
Merged
Merged
Conversation
SOURCE_COMMIT was never passed at build time, so the endpoint always returned the fallback value. Pass it as a Docker ARG/ENV so the running container reflects the actual commit used to build the image. Drop the version field because the displayed value was stale. https://claude.ai/code/session_015DzWsQFLrDMb1xz63nrx3T
…ction Switch from SOURCE_COMMIT to the COMMIT and VERSION args now provided by the updated action (bac5580). Dockerfile bakes both into ENV vars; the info controller reads them at runtime, falling back to package.json version for local non-Docker runs. https://claude.ai/code/session_015DzWsQFLrDMb1xz63nrx3T
Remove build-args from the test Docker build step (the action handles injection). Drop the config.VERSION fallback so version comes only from the VERSION env var set at image build time. Remove the build:commit script and its callers in dist and start:dev. https://claude.ai/code/session_015DzWsQFLrDMb1xz63nrx3T
VERSION and COMMIT are now baked in at Docker build time, so there is no need to locate and parse package.json at startup. Read VERSION from process.env.VERSION (falls back to 'unknown' for local non-Docker runs) and drop the find-up dependency entirely. https://claude.ai/code/session_015DzWsQFLrDMb1xz63nrx3T
ffflorian
changed the title
Add COMMIT to ServerConfig interface and use config.COMMIT/config.VERSION in the info controller instead of reading process.env directly. https://claude.ai/code/session_015DzWsQFLrDMb1xz63nrx3T
ffflorian
changed the title
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 6, 2026
## [1.14.3](v1.14.2...v1.14.3) (2026-06-06) ### Bug Fixes * show real build commit and version ([#1862](#1862)) ([756af41](756af41))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMITandVERSIONbuild args (provided by thedocker-image-releaseaction) intoENVvars so the running container knows what it was built from./_infonow readsCOMMITandVERSIONfrom the environment instead of falling back to placeholder strings.find-updependency removed — version no longer needs to be read frompackage.jsonat runtime.build:commitscript and its references indistandstart:devremoved.https://claude.ai/code/session_015DzWsQFLrDMb1xz63nrx3T