Fix bop test #55
Merged
Fix bop test #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 'use feature "bitwise"' is enabled, the parser renames bitwise operators to binary& binary| binary^ to distinguish numeric bitwise ops from string bitwise ops (&. |. ^.). These renamed operators were already registered in OperatorHandler and have implementations in BitwiseOperators, but they were missing from the EmitBinaryOperatorNode case statement. This fixes the compilation error 'Not implemented operator: binary&' when using bitwise operators with the bitwise feature enabled. Progress on t/op/bop.t: Now runs 215 tests (was failing at parse/compile time)
The backslash operator (\) was evaluating all non-\& operands in LIST context, which caused issues when creating references to constant subs or other expressions that return scalars. For example, \PVBM where PVBM is a constant sub would evaluate PVBM() in LIST context, returning a RuntimeList, then call createReference() on it which throws 'create reference of list not implemented'. This fix changes the backslash operator to evaluate most operands in SCALAR context (the natural context for creating a reference to a value). LIST context is only used for actual list-producing operations like @ and % variables, or explicit ListNodes. This fixes the remaining failures in t/op/bop.t related to references. Progress on t/op/bop.t: Now passes 313 out of 522 tests (59%)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.