Fix bitwise operators: reference stringification, shift edge cases, a… #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd integer shifts Fixes t/op/bop.t from 68% to 89% passing (356→465 tests) Major improvements: - Add binary&, binary|, binary^ operator support for 'use feature bitwise' - Fix reference stringification in bitwise operators (& | ^ ~) - Non-numeric values now properly stringify instead of numify - Uses ScalarUtils.looksLikeNumber() to detect numeric vs string ops - Implement proper shift operator semantics - Handle negative shifts (reverse direction) - Implement 32-bit UV semantics for unsigned shifts - Add integerShiftLeft/Right for 'use integer' pragma - Shifts >= 32 properly return 0 (or -1/0 for signed) - Detect 'use integer' pragma in EmitBinaryOperator for shifts Files modified: - BitwiseOperators.java: Enhanced operators, added integer shift methods - EmitBinaryOperator.java: Added 'use integer' detection for shifts - EmitBinaryOperatorNode.java: Added binary& | ^ operator cases Remaining edge cases (57/522 tests): tied variable magic, extreme shift values, and minor error message differences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd integer shifts
Fixes t/op/bop.t from 68% to 89% passing (356→465 tests)
Major improvements:
Files modified:
Remaining edge cases (57/522 tests): tied variable magic, extreme shift values, and minor error message differences.