Skip to content

implement unsafe_read for for ReadableFile #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2020
Merged

implement unsafe_read for for ReadableFile #68

merged 2 commits into from
May 18, 2020

Conversation

@chris-b1
Copy link
Contributor

This also has some light refactoring to pull out the common steps out of _read

ref felipenoris/XLSX.jl#135

I get about a 6x speedup on a modest sized Excel file

# PR
julia> @btime XLSX.readtable(f, "Sheet1")
  129.633 ms (417325 allocations: 17.26 MiB)

# master
julia> @btime XLSX.readtable(f, "Sheet1")
  767.820 ms (4570005 allocations: 184.98 MiB)

@chris-b1 chris-b1 mentioned this pull request May 15, 2020
Closed
fhs
fhs approved these changes May 18, 2020
View reviewed changes
Copy link
Owner

@fhs fhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fhs fhs merged commit 7b5c5be into fhs:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhs fhs fhs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chris-b1 @fhs