Skip to content

Always use unused namespace key in output #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Always use unused namespace key in output #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/translation-linter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@
*/
'fields' => [
'locale' => true,
'namespace' => false,
'key' => true,
'value' => true,
],
Expand Down
3 changes: 1 addition & 2 deletions src/Data/ResultObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ public function toArray()
{
return [
'locale' => $this->locale,
'namespace' => $this->namespaceHint,
'key' => $this->key,
'key' => $this->namespaceHintedKey,
'value' => $this->value,
];
}
Expand Down
52 changes: 26 additions & 26 deletions tests/.pest/snapshots/Commands/UnusedCommandTest/it_errors_with_default_no_filters.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@

ERROR 22 unused translations found.

+--------+-----------+------------------------------------+------------------------------+
| Locale | Namespace | Key | Value |
+--------+-----------+------------------------------------+------------------------------+
| en | example | Unused Vendor PHP Class | I am unused in php class |
| en | example | Unused Vendor Blade File | I am unused in blade |
| en | example | Unused Vendor Vue Component | I am unused in vue component |
| en | example | example.unused | I am unused in php class |
| en | example | example.blade.choice.unused | I am unused in blade |
| en | example | example.blade.lang.unused | I am unused in blade |
| en | example | example.vue.unused | I am unused in vue component |
| en | example | folder/example.unused | I am unused in php class |
| en | example | folder/example.blade.choice.unused | I am unused in blade |
| en | example | folder/example.blade.lang.unused | I am unused in blade |
| en | example | folder/example.vue.unused | I am unused in vue component |
| en | | Unused PHP Class | I am unused in php class |
| en | | Unused Blade File | I am unused in blade |
| en | | Unused Vue Component | I am unused in vue component |
| en | | example.unused | I am unused in php class |
| en | | example.blade.choice.unused | I am unused in blade |
| en | | example.blade.lang.unused | I am unused in blade |
| en | | example.vue.unused | I am unused in vue component |
| en | | folder/example.unused | I am unused in php class |
| en | | folder/example.blade.choice.unused | I am unused in blade |
| en | | folder/example.blade.lang.unused | I am unused in blade |
| en | | folder/example.vue.unused | I am unused in vue component |
+--------+-----------+------------------------------------+------------------------------+
+--------+---------------------------------------------+------------------------------+
| Locale | Key | Value |
+--------+---------------------------------------------+------------------------------+
| en | Unused Vendor PHP Class | I am unused in php class |
| en | Unused Vendor Blade File | I am unused in blade |
| en | Unused Vendor Vue Component | I am unused in vue component |
| en | example::example.unused | I am unused in php class |
| en | example::example.blade.choice.unused | I am unused in blade |
| en | example::example.blade.lang.unused | I am unused in blade |
| en | example::example.vue.unused | I am unused in vue component |
| en | example::folder/example.unused | I am unused in php class |
| en | example::folder/example.blade.choice.unused | I am unused in blade |
| en | example::folder/example.blade.lang.unused | I am unused in blade |
| en | example::folder/example.vue.unused | I am unused in vue component |
| en | Unused PHP Class | I am unused in php class |
| en | Unused Blade File | I am unused in blade |
| en | Unused Vue Component | I am unused in vue component |
| en | example.unused | I am unused in php class |
| en | example.blade.choice.unused | I am unused in blade |
| en | example.blade.lang.unused | I am unused in blade |
| en | example.vue.unused | I am unused in vue component |
| en | folder/example.unused | I am unused in php class |
| en | folder/example.blade.choice.unused | I am unused in blade |
| en | folder/example.blade.lang.unused | I am unused in blade |
| en | folder/example.vue.unused | I am unused in vue component |
+--------+---------------------------------------------+------------------------------+
80 changes: 40 additions & 40 deletions .../snapshots/Commands/UnusedCommandTest/it_errors_with_multiple_locales_and_no_filters.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,43 +1,43 @@

ERROR 36 unused translations found.

+--------+-----------+------------------------------------+----------------------------------------------------+
| Locale | Namespace | Key | Value |
+--------+-----------+------------------------------------+----------------------------------------------------+
| en | example | Unused Vendor PHP Class | I am unused in php class |
| en | example | Unused Vendor Blade File | I am unused in blade |
| en | example | Unused Vendor Vue Component | I am unused in vue component |
| en | example | example.unused | I am unused in php class |
| en | example | example.blade.choice.unused | I am unused in blade |
| en | example | example.blade.lang.unused | I am unused in blade |
| en | example | example.vue.unused | I am unused in vue component |
| en | example | folder/example.unused | I am unused in php class |
| en | example | folder/example.blade.choice.unused | I am unused in blade |
| en | example | folder/example.blade.lang.unused | I am unused in blade |
| en | example | folder/example.vue.unused | I am unused in vue component |
| en | | Unused PHP Class | I am unused in php class |
| en | | Unused Blade File | I am unused in blade |
| en | | Unused Vue Component | I am unused in vue component |
| en | | example.unused | I am unused in php class |
| en | | example.blade.choice.unused | I am unused in blade |
| en | | example.blade.lang.unused | I am unused in blade |
| en | | example.vue.unused | I am unused in vue component |
| en | | folder/example.unused | I am unused in php class |
| en | | folder/example.blade.choice.unused | I am unused in blade |
| en | | folder/example.blade.lang.unused | I am unused in blade |
| en | | folder/example.vue.unused | I am unused in vue component |
| de | example | Unused Vendor PHP Class | Ich werde in einer PHP-Klasse nicht verwendet |
| de | example | Unused Vendor Blade File | Ich werde in Blade nicht verwendet |
| de | example | Unused Vendor Vue Component | Ich werde in einem Vue-Komponenten nicht verwendet |
| de | | Unused PHP Class | Ich werde in einer PHP-Klasse nicht verwendet |
| de | | Unused Blade File | Ich werde in Blade nicht verwendet |
| de | | Unused Vue Component | Ich werde in einem Vue-Komponenten nicht verwendet |
| de | | example.unused | Ich werde in einer PHP-Klasse nicht verwendet |
| de | | example.blade.choice.unused | Ich werde in Blade nicht verwendet |
| de | | example.blade.lang.unused | Ich werde in Blade nicht verwendet |
| de | | example.vue.unused | Ich werde in einem Vue-Komponenten nicht verwendet |
| de | | folder/example.unused | Ich werde in einer PHP-Klasse nicht verwendet |
| de | | folder/example.blade.choice.unused | Ich werde in Blade nicht verwendet |
| de | | folder/example.blade.lang.unused | Ich werde in Blade nicht verwendet |
| de | | folder/example.vue.unused | Ich werde in einem Vue-Komponenten nicht verwendet |
+--------+-----------+------------------------------------+----------------------------------------------------+
+--------+---------------------------------------------+----------------------------------------------------+
| Locale | Key | Value |
+--------+---------------------------------------------+----------------------------------------------------+
| en | Unused Vendor PHP Class | I am unused in php class |
| en | Unused Vendor Blade File | I am unused in blade |
| en | Unused Vendor Vue Component | I am unused in vue component |
| en | example::example.unused | I am unused in php class |
| en | example::example.blade.choice.unused | I am unused in blade |
| en | example::example.blade.lang.unused | I am unused in blade |
| en | example::example.vue.unused | I am unused in vue component |
| en | example::folder/example.unused | I am unused in php class |
| en | example::folder/example.blade.choice.unused | I am unused in blade |
| en | example::folder/example.blade.lang.unused | I am unused in blade |
| en | example::folder/example.vue.unused | I am unused in vue component |
| en | Unused PHP Class | I am unused in php class |
| en | Unused Blade File | I am unused in blade |
| en | Unused Vue Component | I am unused in vue component |
| en | example.unused | I am unused in php class |
| en | example.blade.choice.unused | I am unused in blade |
| en | example.blade.lang.unused | I am unused in blade |
| en | example.vue.unused | I am unused in vue component |
| en | folder/example.unused | I am unused in php class |
| en | folder/example.blade.choice.unused | I am unused in blade |
| en | folder/example.blade.lang.unused | I am unused in blade |
| en | folder/example.vue.unused | I am unused in vue component |
| de | Unused Vendor PHP Class | Ich werde in einer PHP-Klasse nicht verwendet |
| de | Unused Vendor Blade File | Ich werde in Blade nicht verwendet |
| de | Unused Vendor Vue Component | Ich werde in einem Vue-Komponenten nicht verwendet |
| de | Unused PHP Class | Ich werde in einer PHP-Klasse nicht verwendet |
| de | Unused Blade File | Ich werde in Blade nicht verwendet |
| de | Unused Vue Component | Ich werde in einem Vue-Komponenten nicht verwendet |
| de | example.unused | Ich werde in einer PHP-Klasse nicht verwendet |
| de | example.blade.choice.unused | Ich werde in Blade nicht verwendet |
| de | example.blade.lang.unused | Ich werde in Blade nicht verwendet |
| de | example.vue.unused | Ich werde in einem Vue-Komponenten nicht verwendet |
| de | folder/example.unused | Ich werde in einer PHP-Klasse nicht verwendet |
| de | folder/example.blade.choice.unused | Ich werde in Blade nicht verwendet |
| de | folder/example.blade.lang.unused | Ich werde in Blade nicht verwendet |
| de | folder/example.vue.unused | Ich werde in einem Vue-Komponenten nicht verwendet |
+--------+---------------------------------------------+----------------------------------------------------+
4 changes: 0 additions & 4 deletions tests/Commands/UnusedCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
});

it('errors with default no filters', function () {
config()->set('translation-linter.unused.fields.namespace', true);
config()->set('translation-linter.unused.filters', []);

withoutMockingConsoleOutput();
Expand All @@ -41,7 +40,6 @@

it('errors with default no fields', function () {
config()->set('translation-linter.unused.fields.locale', false);
config()->set('translation-linter.unused.fields.namespace', false);
config()->set('translation-linter.unused.fields.key', false);
config()->set('translation-linter.unused.fields.value', false);

Expand All @@ -63,7 +61,6 @@

it('errors with multiple locales and no filters', function () {
config()->set('translation-linter.lang.locales', ['en', 'de']);
config()->set('translation-linter.unused.fields.namespace', true);
config()->set('translation-linter.unused.filters', []);

withoutMockingConsoleOutput();
Expand All @@ -75,7 +72,6 @@

it('generates baseline file then successfully ignores baseline keys', function () {
config()->set('translation-linter.lang.locales', ['en', 'de']);
config()->set('translation-linter.unused.fields.namespace', true);
config()->set('translation-linter.unused.filters', [IgnoreKeysFromUnusedBaselineFileFilter::class]);

withoutMockingConsoleOutput();
Expand Down