Crash when applying diff, starting with v5.0.7

[6a5p1]

The diff apply operation results in a crash at the relocateGroup operation.
node.removeChild - crashes, in chrome debugger (in my example) - node.childNodes[diff[options._const.from]] - the index is > than the number of childNodes.
Please take a look as I had to downgrade from 5.1.2 to 5.0.6 to find a working version

[johanneswilm]

@6a5p1 It's very difficult for me to work on this without an example. Could you provide me with at the very least an example of what you were diffing? I am assuming you did no manual change to anything at all.

[6a5p1]

sure, I'll be back with an example asap

[6a5p1]

Using version 5.1.2

OLD:
`

<div class="test-c"><div class="test-0">
    
    <div class="test-1">
        
            
                <span>XX</span>
            
        
            
                <span>XX</span>
            
        
            
                <span>XX</span>
            
        
            
                <span>XX</span>
            
                <span>XX</span>
            
                <span>XX</span>
            
                <span>XX</span>
            
        
    </div></div></div>

`

NEW:
`

<div class="test-c"><div class="test-0">
    
    <div class="test-1">
        
            
                <span>XX</span>
            
        
            
                <span>XX</span>
            
                <span>XX</span>
            
                <span>XX</span>
            
                <span>XX</span>
            
                <span>XX</span>
            
                <span>XX</span>
            
        
    </div></div></div>

`

Error:
TypeError: Failed to execute 'removeChild' on 'Node': parameter 1 is not of type 'Node'. at module.js:228:1 at Array.map (<anonymous>) at applyDiff (module.js:227:1) at module.js:290:1 at Array.every (<anonymous>) at applyDOM (module.js:289:1) at push../node_modules/diff-dom/dist/module.js.DiffDOM.apply (module.js:1866:1)

Diff:
[{"action":"modifyTextElement","route":[1,0,1,4],"oldValue":"\n \n \n \n ","newValue":"\n \n "},{"action":"addTextElement","route":[1,0,1,10],"value":"\n \n "},{"action":"relocateGroup","groupLength":1,"from":1,"to":11,"route":[1,0,1]},{"action":"relocateGroup","groupLength":1,"from":2,"to":13,"route":[1,0,1]},{"action":"relocateGroup","groupLength":5,"from":3,"to":1,"route":[1,0,1]},{"action":"relocateGroup","groupLength":1,"from":14,"to":9,"route":[1,0,1]},{"action":"relocateGroup","groupLength":5,"from":10,"to":4,"route":[1,0,1]},{"action":"relocateGroup","groupLength":11,"from":9,"to":-4,"route":[1,0,1]},{"action":"replaceElement","oldValue":{"nodeName":"#text","data":"\n \n \n "},"newValue":{"nodeName":"SPAN","childNodes":[{"nodeName":"#text","data":"XX"}]},"route":[1,0,1,5]},{"action":"replaceElement","oldValue":{"nodeName":"SPAN","childNodes":[{"nodeName":"#text","data":"XX"}]},"newValue":{"nodeName":"#text","data":"\n \n "},"route":[1,0,1,6]},{"action":"replaceElement","oldValue":{"nodeName":"#text","data":"\n \n "},"newValue":{"nodeName":"SPAN","childNodes":[{"nodeName":"#text","data":"XX"}]},"route":[1,0,1,7]},{"action":"replaceElement","oldValue":{"nodeName":"#text","data":"\n \n \n \n "},"newValue":{"nodeName":"SPAN","childNodes":[{"nodeName":"#text","data":"XX"}]},"route":[1,0,1,9]},{"action":"replaceElement","oldValue":{"nodeName":"SPAN","childNodes":[{"nodeName":"#text","data":"XX"}]},"newValue":{"nodeName":"#text","data":"\n \n "},"route":[1,0,1,10]},{"action":"replaceElement","oldValue":{"nodeName":"#text","data":"\n \n "},"newValue":{"nodeName":"SPAN","childNodes":[{"nodeName":"#text","data":"XX"}]},"route":[1,0,1,11]},{"action":"replaceElement","oldValue":{"nodeName":"SPAN","childNodes":[{"nodeName":"#text","data":"XX"}]},"newValue":{"nodeName":"#text","data":"\n \n "},"route":[1,0,1,12]},{"action":"modifyTextElement","route":[1,0,1,14],"oldValue":"\n \n ","newValue":"\n \n \n "},{"action":"removeElement","route":[1,0,1,15],"element":{"nodeName":"SPAN","childNodes":[{"nodeName":"#text","data":"XX"}]}}]

[johanneswilm]

Ok, I will test. So the only difference is one of whitespace, correct?

[6a5p1]

I added a printscreen with my actual html (before and after, old and new) to help you with debugging.
Note that the html starts and ends with blank linkes (\n), maybe they are important, don't know.

Thank you in advance!

[6a5p1]

Hello! Do you have any update here? And thank you!

[johanneswilm]

@6a5p1 fixed in 5.1.4